-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX #1678: update isReadyLock state to fix deadlock on second render #1679
Conversation
update isReadyLock state to fix deadlock on second render
Codecov Report
@@ Coverage Diff @@
## master #1679 +/- ##
==========================================
+ Coverage 78.60% 78.64% +0.04%
==========================================
Files 74 74
Lines 3010 3011 +1
Branches 624 624
==========================================
+ Hits 2366 2368 +2
Misses 590 590
+ Partials 54 53 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi. Thank you for your contribution. Could you please also add some tests for it?
Hi, @dangreen . I'm new in this project, so could you please show me a file there such async test should be placed? |
@IlyaSV Please create file import { Canvg } from '../src'
describe('Canvg', () => {
describe('render', () => {
it('should render twice without deadlock', () => {
// ...
});
})
}) |
Co-authored-by: Dan Onoshko <danon0404@gmail.com>
Co-authored-by: Dan Onoshko <danon0404@gmail.com>
@IlyaSV Thank you! |
calling "render()" twice fixes some render issues (see #1678 ).
This update fixes deadlock on calling second "render()".