Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust NoDynamicWhereRule to not restrict the usage likes of wherePivot #92

Conversation

jeremynikolic
Copy link
Contributor

This adds BelongsToMany to be looked at so that wherePivot (and other pivot related methods) are not detected as Dynamic wheres

This adds BelongsToMany to be looked at so that wherePivot (and other pivot related methods) are not detected as Dynamic wheres
@codecov
Copy link

codecov bot commented Aug 23, 2022

Codecov Report

Merging #92 (2345184) into master (5148672) will decrease coverage by 0.85%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master      #92      +/-   ##
============================================
- Coverage     82.15%   81.30%   -0.86%     
- Complexity      112      113       +1     
============================================
  Files             8        8              
  Lines           213      214       +1     
============================================
- Hits            175      174       -1     
- Misses           38       40       +2     
Impacted Files Coverage Δ
src/Rules/NoDynamicWhereRule.php 85.71% <100.00%> (-3.38%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@canvural
Copy link
Owner

canvural commented Aug 23, 2022

Thank you. Looks good to me!

Did you test this in your own project? Does it resolve the issue? I'd like to confirm that before merging also.

Looks good 👍🏽

@canvural canvural merged commit 59724e0 into canvural:master Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants