Improve the detection of global/root object

caolan · Jun 24, 2015 · d2dd36b · d2dd36b
1 parent 4722bb5
commit d2dd36b
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 11 deletions.
diff --git a/.jshintrc b/.jshintrc
@@ -20,6 +20,7 @@
     "browser": true,
     "node": true,
     "globals": {
+        "self": true,
         "define": true
     }
 }
diff --git a/lib/async.js b/lib/async.js
@@ -11,17 +11,14 @@
     function noop() {}
 
     // global on the server, window in the browser
-    var root, previous_async;
-
-    if (typeof window == 'object' && this === window) {
-        root = window;
-    }
-    else if (typeof global == 'object' && this === global) {
-        root = global;
-    }
-    else {
-        root = this;
-    }
+    var previous_async;
+
+    // Establish the root object, `window` (`self`) in the browser, `global`
+    // on the server, or `this` in some virtual machines. We use `self`
+    // instead of `window` for `WebWorker` support.
+    var root = typeof self === 'object' && self.self === self && self ||
+            typeof global === 'object' && global.global === global && global ||
+            this;
 
     if (root != null) {
         previous_async = root.async;