Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

static doc site generation #1202

Merged
merged 41 commits into from Jun 30, 2016
Merged

static doc site generation #1202

merged 41 commits into from Jun 30, 2016

Conversation

hargasinski
Copy link
Collaborator

@hargasinski hargasinski commented Jun 29, 2016

I think the site is finally in a position to be published. The site is generated in the docs folder (not included in the PR) through npm run jsdoc.

For generating the gh-pages (if you host it through that), I could make a PR for a gh-pages branch, which would just include a package.json similar to this one.

/cc @aearly @megawac

Sample site: http://hargasinski.github.io/async/index.html
Fixes #1083, Resolves #1135, Closes #1191

This was referenced Jun 29, 2016
@megawac
Copy link
Collaborator

megawac commented Jun 29, 2016

Mind regenerating with the new logo? #1203 #1204

@megawac
Copy link
Collaborator

megawac commented Jun 29, 2016

I'm also not a big fan of the table format for listing parameters. Seems kinda ugly =/

@aearly
Copy link
Collaborator

aearly commented Jun 29, 2016

I'd say this is good for now. I was going to create a makefile task that handles generating the docs and pushing to the gh-pages branch.

We can make the parameter tables to look more like text through CSS - that was going to be one of my first tweaks. 😛

@hargasinski
Copy link
Collaborator Author

I think I may have pulled the logo changes from master incorrectly, but everything appears to be working? I opted for storing a copy of the logo in the docs, as opposed to using raw.githubusercontent.com... so that we don't accidentally break it on the site if we decide to move it or something. @aearly if you have ideas for the styling the parameter tables on the site, then I'll leave that part for you. CSS is exactly my specialty 😛. The one thing I like about the tables is that they allow you to quickly scan the info, even if it doesn't look the most appealing.

@megawac
Copy link
Collaborator

megawac commented Jun 30, 2016

I'm also not quite satisfied with how our typedefs are currently showign (QueueObject and CargoObject). Not exactly the clearest about what they are or how to use them

@aearly aearly merged commit 13fcbf4 into caolan:master Jun 30, 2016
@megawac
Copy link
Collaborator

megawac commented Jun 30, 2016

Alex, do we want to keep the github readme as is or have it point to the
new site
On Jun 30, 2016 7:02 PM, "Alex Early" notifications@github.com wrote:

Merged #1202 #1202.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1202 (comment), or mute the
thread
https://github.com/notifications/unsubscribe/ADUIEJ4rYDTubx6a7dKkUl-gNSuf2VTqks5qREr_gaJpZM4JA0wG
.

@aearly
Copy link
Collaborator

aearly commented Jun 30, 2016

Let me get a publishing script in place. Once published we'll want the readme to mainly point to the docs site.

aearly added a commit that referenced this pull request Jun 30, 2016
@aearly
Copy link
Collaborator

aearly commented Jun 30, 2016

http://caolan.github.io/async/ !!!

@hargasinski
Copy link
Collaborator Author

!! That was fast @aearly! I'm really glad it's live 😄

@ivanseidel
Copy link
Contributor

Hey guys! Witch branch should I make changes to the website? I want to help with a few colors in it.. =)

@megawac
Copy link
Collaborator

megawac commented Jun 30, 2016

I believe the main one is async-readme.jpg

@aearly
Copy link
Collaborator

aearly commented Jun 30, 2016

We're working on master now.

@Kikobeats
Copy link
Contributor

functional and useful docs examples using jsdocs: http://barbajs.org/docs/

@aearly
Copy link
Collaborator

aearly commented Jul 1, 2016

Docs are available here: http://caolan.github.io/async/

@megawac
Copy link
Collaborator

megawac commented Jul 5, 2016

@caolan have you seen the new docs?! Also can you update the repos header to include a link to the site?

@caolan
Copy link
Owner

caolan commented Jul 6, 2016

@megawac I've updated the github header - the docs look great :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants