Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup make publish script #805

Merged
merged 2 commits into from
Jun 28, 2015
Merged

Setup make publish script #805

merged 2 commits into from
Jun 28, 2015

Conversation

megawac
Copy link
Collaborator

@megawac megawac commented Jun 24, 2015

This adds a make task which:

  • Tests and builds async
  • Adds a commit bumping the package.json and tags the commit
  • Adds the dist/ to the published package (only on github - useful for CDNs) (only for releases)
  • Pushes to the commit and tag
  • Publishs to npm

Usage make release-patch

Reference: https://github.com/davidchambers/xyz

@megawac megawac force-pushed the building branch 2 times, most recently from c21cec4 to f89af38 Compare June 24, 2015 18:55
@aearly
Copy link
Collaborator

aearly commented Jun 24, 2015

Would be nice if it also ran support/sync-package-managers.js.

It also looks like xyzcreates a tag of the form v1.2.3 -- can it also do 1.2.3? IIRC Bower expects the latter.

@megawac
Copy link
Collaborator Author

megawac commented Jun 24, 2015

Semver supports both tag formats and yeah, I saw the syncpackagemanagers
and didn't add it for whatever reason. I'll do that when I get back
On Jun 24, 2015 6:17 PM, "Alexander Early" notifications@github.com wrote:

Would be nice if it also ran support/sync-package-managers.js. It also
looks like xyzcreates a tag of the form v1.2.3 -- can it also do 1.2.3?
IIRC Bower expects the latter.


Reply to this email directly or view it on GitHub
#805 (comment).

@megawac
Copy link
Collaborator Author

megawac commented Jun 24, 2015

BTW is there an irc,slack or gitter chanmel for this project?
On Jun 24, 2015 6:20 PM, "Graeme Yeates" megawac@gmail.com wrote:

Semver supports both tag formats and yeah, I saw the syncpackagemanagers
and didn't add it for whatever reason. I'll do that when I get back
On Jun 24, 2015 6:17 PM, "Alexander Early" notifications@github.com
wrote:

Would be nice if it also ran support/sync-package-managers.js. It also
looks like xyzcreates a tag of the form v1.2.3 -- can it also do 1.2.3?
IIRC Bower expects the latter.


Reply to this email directly or view it on GitHub
#805 (comment).

@aearly
Copy link
Collaborator

aearly commented Jun 24, 2015

I just added a gitter room. Currently it's freezing any browser I load it with, though....

@megawac
Copy link
Collaborator Author

megawac commented Jun 25, 2015

It also looks like xyzcreates a tag of the form v1.2.3 -- can it also do 1.2.3? IIRC Bower expects the latter.

I have wayyy to intimate knowledge of semver cause of jsdelivr and semvish

var S = require('semver')
S.satisfies('v0.1.1', '0.1.1')
S.eq('v0.1.1', '0.1.1')

If bower doesn't support v* tags then it's a bug on their end

aearly added a commit that referenced this pull request Jun 28, 2015
Setup make publish script
@aearly aearly merged commit 3b75568 into caolan:master Jun 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants