Added support to runModules directly in minimal and default reporters #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For reference, check out issue #105 on caolan/nodeunit |
… If none is specified, it still defaults to document.body
|
Added one more change. The browser reporter always writes to document.body, which may not be good if there are multiple elements on the page, e.g. a testrunner interface or other reporting. Since nodeunit.run() in the browser already supports an options object as a second parameter, I added a "div" option. If it is present, the results of the test are written to the passed element; if not, it still defaults to document.body, so the default behaviour is unchanged. This makes it much more useful in the browser. |
|
caolan? Any movement on this? |
caolan
pushed a commit
that referenced
this pull request
Oct 29, 2011
Added support to runModules directly in minimal and default reporters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for you to create tests directly or in non-standard files. I should probably extend it to html.js as well, haven't gotten to it yet.
Just adds some flexibility with minimal changes, and allows me to, for example, share tests between browsers that expect global vars or objects, and node tests.