-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error while enabling plugin in Spigot 1.12 #40
Comments
Now I get this after logging on and the inventory is empty now.
|
@alphanimal I'll check it later. seems 1.12 change the NBT format. |
I think it's working now. I'll test if it transports the inventory from 1.11 to 1.12 correctly. I only get a warning now when I log on:
|
@alphanimal Alright. That not a very important warn. :-) |
OK so for player who had their inventory stored in 1.11, when they first join a 1.12 server they lose their inventory with the following error:
That is still the case with the newest build |
It's pretty bad now, because every player who logs in from now on basically loses their inventory. The format seems to have changed. Here's the inventory field from a player who hasn't logged on in 1.12 yet:
Here's the inventory field from a player who has logged on in 1.12:
|
I think the problem is it used to break lines at 76 characters. now all the It also seems to have a fixed length padded by 0x0, judging from all the AAAAAAAAA in the string. |
When I try to remove all the
|
@alphanimal have no idea if NMS changed NBT format. This plugin call NMS's origin save/load method by reflect. |
OK I have a workaround. I archived the playersql table in the database. So when somebody reconnects it's not trying to load the old inventory from the database but is just using the one in the player file. after the inventory is saved in a new record (in the new format) it can be loaded successfully. Thanks for all your support! |
Maybe you can still implement a safety mechanism for that? Say if it fails to load the inventory for any reason from the database, even if there is an entry there, just make a new entry (overwrite) with the currently loaded inventory. |
@alphanimal I'll do a mechanism not override database column if player load inventory from database failed. |
With this version if I try to load old/invalid data I cannot even log in to the server:
My suggestion is that it should ignore the data that cannot beloaded and just use the inventory from the player file. Once it gets saved to the database again it's OK to load the next time. |
@alphanimal Umm... Okay I'll made it. |
Try https://github.com/caoli5288/PlayerSQL/releases/tag/v2.5.1b2 and set/add |
That is working! very nice! I'd still make it the default behaviour, but that works. thank you so much! |
When loading the plugin in Spigot 1.12 I get the following exception:
The text was updated successfully, but these errors were encountered: