Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find member does not include all appropriate members in results #320

Closed
r-a303931 opened this issue Jul 21, 2022 · 1 comment · Fixed by #401
Closed

Find member does not include all appropriate members in results #320

r-a303931 opened this issue Jul 21, 2022 · 1 comment · Fixed by #401
Assignees
@r-a303931
Labels
bug Something isn't working Critical: must fix Fix as soon as able, not deferred for next version

Comments

@r-a303931
Copy link
Member

r-a303931 commented Jul 21, 2022 •
edited by grioux-neo
Loading

Describe the bug
When using the echelon find member feature, only members who hold duty positions are included in the search results

To Reproduce

  1. Go to echelon admin dashboard
  2. Click on 'Find Member'
  3. Search for cadet

Expected behavior
The cadet that is searched for should appear

Actual behavior
No cadets appear in the search results
@r-a303931 r-a303931 added bug Something isn't working Critical: must fix Fix as soon as able, not deferred for next version labels Jul 21, 2022
@r-a303931 r-a303931 self-assigned this Jul 21, 2022
@grioux-neo grioux-neo changed the title Find member does not include cadets in search Find member does not include all appropriate members in results Jan 3, 2024
@grioux-neo
Copy link
Contributor

Need to look at lines 90-180 in packages/server/src/api/member/membersearch.ts
SQL query is sufficient to pull appropriate data. Somewhere in the javascript, members who do not hold duty positions are filtered out.

grioux-neo pushed a commit that referenced this issue Jan 12, 2024
fix: Find member includes all appropriate members in results
a4247f5 
ISSUES CLOSED: #320
@grioux-neo grioux-neo mentioned this issue Jan 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@r-a303931 r-a303931

Labels
bug Something isn't working Critical: must fix Fix as soon as able, not deferred for next version
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Find member includes all appropriate members in results cap-md089/evmplus-v6
2 participants
@r-a303931 @grioux-neo