fix: navigator.mediaDevices returning undefined on macOS
#7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes `navigator.mediaDevices` being undefiend in mac. Added plist files to access permissions. * `useDidMountEffect` so that the encoder doesn't register itself twice as there is no cleanup for the `register` provided by the library
|
@mooyg is attempting to deploy a commit to the Reflio Team on Vercel. A member of the Team first needs to authorize it. |
|
Thanks for this @mooyg - merged! |
richiemcilroy
added a commit
that referenced
this pull request
Jan 8, 2024
fix: `navigator.mediaDevices` returning `undefined` on macOS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue mentioned here through PLIST files to get the permissions for the media devices.
Another fix for encoder being registered twiced.
This might still not work on LINUX as the tauri linux webview doesn't support it.