Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(): update to v4 #244

Merged
merged 2 commits into from
Sep 20, 2022
Merged

feat(): update to v4 #244

merged 2 commits into from
Sep 20, 2022

Conversation

rdlabo
Copy link
Member

@rdlabo rdlabo commented Aug 5, 2022

By using next tag, This plugin can try to test on Capacitor 4.

% npm install @capacitor-community/camera-preview@next

https://github.com/capacitor-community/camera-preview/releases/tag/v4.0.0-0

However, this update was done automatically by @rdlabo/capacitor-plugin-to-v4 ,and has not been confirmed to work.

https://github.com/rdlabo-team/capacitor-plugin-to-v4

If you have any problems using it, please comment on this thread.

@maintainer Released with next tag to make the world compatible with Capacitor v4. Please check out this pull request and decide if you want to merge or not. Thanks for all your great work, and we look forward to working with you in the future.

@pbowyer
Copy link
Collaborator

pbowyer commented Aug 13, 2022

Hi @rdlabo thanks for the pull request. I'm not understanding this - if I merge it into master, how does that make the plugin available with @next rather than be the main version?

@pbowyer pbowyer mentioned this pull request Aug 13, 2022
@EinfachHans
Copy link

fyi: i will test this on monday and let you know if it works. Code changes looks good so far

@EinfachHans
Copy link

@pbowyer test with Capacitor 4.0.1 and works fine, guess this can be merged 😊

@pbowyer
Copy link
Collaborator

pbowyer commented Sep 20, 2022

Thanks for testing @EinfachHans, much appreciated!

@pbowyer pbowyer merged commit 49e734e into master Sep 20, 2022
@pbowyer pbowyer deleted the feat/v4 branch September 20, 2022 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants