shapes: Add support for polyline, polygon and circle

[hemangsk]

Hi Tafel, congrats on the new release!

Since version 1 lacked a lot of (basic) features

Here's a basic feature you dropped.

Since version 1 lacked a lot of (basic) features, did not have good coding practices, had a poor API

I just have one thing to add here, incase you have a need to scrutinise someone's open source work, consider communicating to the author how they could improve on these things using Issues / Mail / Discussions, instead of going on a bandwagon shaming other people's hard work.

Capacitor community has taught me a lot, and has helped me become a better developer than I was when I started and I KNOW there is so much more to learn ahead.

[tafelnl]

Thanks for the PR!

Hi Tafel, congrats on the new release!

Thanks 🎉

Here's a basic feature you dropped.

I know, thanks for adding it by means of this PR. There's some other functionality that's not finished as well. For example custom marker icons on Android or support for clustering of markers. That's one of the reasons version 2 has been released as a beta first.

I just have one thing to add here, incase you have a need to scrutinise someone's open source work, consider communicating to the author how they could improve on these things using Issues / Mail / Discussions, instead of going on a bandwagon shaming other people's hard work.

I am not sure what you are trying to say with this. But I do not feel like I've said anything that has not been discussed before, or something that is wrong / not true / insulting. There has been plenty of discussion about these topics in which you and I participated as well.

Capacitor community has taught me a lot, and has helped me become a better developer than I was when I started and I KNOW there is so much more to learn ahead.

That's awesome to hear and one of the many advantages Open Source Software offers us.

[gbrits]

In a scenario like this, people spend hours of their free time learning how to write a plugin; chatting and using trial and error to get things working.

I could see how @hemangsk would be gently reminding everyone to be cognisant of the willingness for newcomers to assist.

A softness in approach & wording, especially into the humble beginnings - to acknowledge the time put in to create a foundation & to allow contributions without fear of their work being harshly graded.

Wording like "poor coding practices" will always reinforce imposter syndrome and alienate developers from one another - that's probably what he meant.

We're all just trying our best & learning as fast as we can.

[KevinToala]

Thank you for this PR. For us these functionalities are very important to be able to migrate to this capacitor plugin. :)

[MyTek]

Im trying to use the polygons feature here and i cant get removePolygon() or removeMarker() to work. This PR is from over a year ago though. Is there something better than this people are using now or something? Is this project dead?