Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove only one key initialization condition #247

Merged
merged 1 commit into from
Jan 25, 2023

Conversation

timofey97
Copy link
Contributor

We have a need to work with different stripe accounts in one application. With each payment, we change and initialize different public keys from different companies. But initialization worked painlessly only on ios, on android we found a small flaw in the plugin code.
If you remove the check for an empty publishableKey, then everything works as it should)

If possible, please add this to the update or if you have any ideas on how to improve and secure the code, I will be glad to any suggestions

@netlify
Copy link

netlify bot commented Jan 3, 2023

Deploy Preview for capacitor-community-stripe failed.

Name Link
🔨 Latest commit d4370cd
🔍 Latest deploy log https://app.netlify.com/sites/capacitor-community-stripe/deploys/63b43d0b6aa9ee00091c5693

@rdlabo
Copy link
Member

rdlabo commented Jan 25, 2023

Thanks pull request. We did not consider that kind of usage. Thanks for your contribution!

@rdlabo rdlabo merged commit bed3d9e into capacitor-community:master Jan 25, 2023
@rdlabo
Copy link
Member

rdlabo commented Jan 25, 2023

@timofey97 Did you use this plugin for production? If yes, please tell us what app. This help development this plugin.

👉 #145

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants