Skip to content
This repository has been archived by the owner on Apr 1, 2023. It is now read-only.

duration is in milliseconds, whereas HTMLMediaElement.duration is in seconds #73

Closed
mesqueeb opened this issue Jan 12, 2023 · 1 comment · Fixed by #88
Closed

duration is in milliseconds, whereas HTMLMediaElement.duration is in seconds #73

mesqueeb opened this issue Jan 12, 2023 · 1 comment · Fixed by #88
Labels
breaking change Breaking change priority: sponsor This issue was prioritized by a sponsor. refactor
Milestone
v0.6.0

Comments

@mesqueeb
Copy link

mesqueeb commented Jan 12, 2023 •
edited
Loading

Just wanted to let you know that when you inspect a <video /> element and grab the duration from the HTMLVideoElement (which inherits HTMLMediaElement) the duration will be in seconds.

It might be better to align duration returned by this plugin with the HTMLMediaElement interface, unless there are other mainstream types that use duration for ms instead.

But it would be a breaking change, so not ideal 😅
@mesqueeb mesqueeb mentioned this issue Jan 16, 2023
Closed
@mesqueeb
Copy link
Author

@robingenz if #76 is a limitation, then I believe even stronger in returning seconds instead of ms 😅

@robingenz robingenz added this to the v0.6.0 milestone Jan 20, 2023
@robingenz robingenz added the priority: sponsor This issue was prioritized by a sponsor. label Feb 9, 2023
@robingenz robingenz mentioned this issue Feb 9, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
breaking change Breaking change priority: sponsor This issue was prioritized by a sponsor. refactor
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging a pull request may close this issue.

fix(ios)!: invalid values for duration capawesome-team/capacitor-file-picker
2 participants
@mesqueeb @robingenz