fix(storage): add null check to updateMetadata(...) on Android (#580

)
capawesome-team · Mar 9, 2024 · 59fd3d0 · 59fd3d0
1 parent 506e930
commit 59fd3d0
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/.changeset/ten-ants-nail.md b/.changeset/ten-ants-nail.md
@@ -0,0 +1,5 @@
+---
+'@capacitor-firebase/storage': patch
+---
+
+fix(android): add `null` check to `updateMetadata(...)`
diff --git a/...c/main/java/io/capawesome/capacitorjs/plugins/firebase/storage/FirebaseStoragePlugin.java b/...c/main/java/io/capawesome/capacitorjs/plugins/firebase/storage/FirebaseStoragePlugin.java
@@ -23,6 +23,7 @@ public class FirebaseStoragePlugin extends Plugin {
     public static final String TAG = "FirebaseStorage";
     public static final String ERROR_PATH_MISSING = "path must be provided.";
     public static final String ERROR_URI_MISSING = "uri must be provided.";
+    public static final String ERROR_METADATA_MISSING = "metadata must be provided.";
 
     private FirebaseStorage implementation;
 
@@ -161,6 +162,10 @@ public void updateMetadata(PluginCall call) {
                 return;
             }
             JSObject metadata = call.getObject("metadata");
+            if (metadata == null) {
+                call.reject(ERROR_METADATA_MISSING);
+                return;
+            }
 
             UpdateMetadataOptions options = new UpdateMetadataOptions(path, metadata);
             EmptyResultCallback callback = new EmptyResultCallback() {