Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added performance attributes #509

Closed
wants to merge 3 commits into from

Conversation

triyam
Copy link

@triyam triyam commented Dec 6, 2023

Issue #505

Added putAttribute(...) getAttribute(...) getAttributes(...) removeAttribute(...) putMetric(...) getMetric(...) record(...) to the definations.ts file

I recommend to make the changes in the definitions.ts file first and let me review them before starting with the actual implementation.

As you have mentioned, let me know after reviewing whether to move ahead or not

I am new to open-source, your guidance will be helpful

@triyam triyam changed the title Feat/issues 505 Added performance attributes Dec 6, 2023
@robingenz
Copy link
Member

See #505 (comment)

@robingenz robingenz closed this Dec 7, 2023
@triyam triyam deleted the feat/issues-505 branch December 7, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants