Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CentOS 6.x support. #45

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Added CentOS 6.x support. #45

wants to merge 3 commits into from

Conversation

ereichert
Copy link

This has been tested on CentOS 6.5 and Ubuntu 14.

Refer to https://github.com/puppetlabs/facter/blob/master/lib/facter/operatingsystem/linux.rb if additional operating systems need to be supported or more specific information about the operating system is required.

@XBeg9
Copy link

XBeg9 commented Mar 27, 2015

@bruno- Any updates on this? That's really nice to have this for CentOs.

@bruno-
Copy link
Member

bruno- commented Apr 2, 2015

Hey,
sorry, no I haven't had the time to try this out yet.

@riseshia
Copy link

I'm working on centos with rails and try to use this gem, however, i found out gem doesn't work on centos and this pr also.
is here any updates, or is there any feature to add more?

riseshia added a commit to riseshia/capistrano-unicorn-nginx that referenced this pull request Jun 17, 2015
@rhomeister
Copy link
Contributor

Hi @ereichert. Could you please rebase onto master and squash your commits? How well is this tested on CentOS and Ubuntu?

@ereichert
Copy link
Author

I'll see what I can do some time this week. Regarding testing, I use it weekly on CentOS 6.5 and have never used it on Ubuntu that I recall. There is an issue with restarting unicorn after a deployment but it's not become enough of a nuisance that I'm going to do anything about it.

…tect_os script in the upload task. Corrected the roles for which the upload_os_detection_script task will be run. Made the upload_os_detection_script task a dependency of the setup_initializer.
…ased on whether the deployment is targeting Ubuntu or CentOS. Corrected a path that was broken during refactoring.
@ereichert
Copy link
Author

@rhomeister I think this is ready to go.

@jesperronn
Copy link

I am insterested in this PR, but also saw master...erwald:38f9e9c which seems to work also with Amazon Linux.

As far as I can tell, this PR doesnt work on Amazon Linux (neither lsb_lease or /etc/redhat-release exist on the Amazon Linux I'm testing)

Anybody having experience with this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants