on roles(:role_name) blocks are not skipped correctly

[tetherit]

I have this in my task:

on roles(:agent) do |host|
  puts "this should never run!!!!"
end

When I run it for a server that does not have :agent in the role list, I see this:

 WARN [SKIPPING] No Matching Host for /usr/bin/env sudo echo
this should never run!!!!

I think it would make a lot more sense if the entire block is skipped, otherwise expensive calculations, local database operations, file preparations, all kinds of local stuff is still ran when it should really be skipped.

[leehambley]

Happy to take a PR if you can make it work without breaking backwards
compatibility, this will need to be implemented in sshkit.
On 28 Oct 2013 23:18, "hackeron" notifications@github.com wrote:

I have this in my task:

on roles(:agent) do |host|
puts "this should never run!!!!"end

When I run it for a server that does not have :agent in the role list, I
see this:

WARN [SKIPPING] No Matching Host for /usr/bin/env sudo echo
this should never run!!!!

I think it would make a lot more sense if the entire block is skipped,
otherwise expensive calculations, local database operations, file
preparations, all kinds of local stuff is still ran when it should really
be skipped.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/740
.

[tetherit]

I will have a look but I am not familiar with the code.

This workaround seems to work though! -

on roles(:cloud) do |host|
      next unless host

[leehambley]

I suppose the question is what should happen in this case:

on [] do |host|
  puts "this should never run!!!!"
end

As in that event, on evaluates the block once, in each server backend instance, and if there are none, then nothing should happen.

[leehambley]

Closing, although I admit this is a problem, because I think it was fixed by a recent PR. I'd be really, really glad to see this fixed, and I really thought it was.