New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use svnversion to capture svn revision number #1013
Conversation
Can you please acknowledge that you're happy enough that you have adhered to the contributor guidelines? https://github.com/capistrano/capistrano/blob/master/CONTRIBUTING.md#submitting-a-pull-request (Also, please squash to one commit, fix the docs, etc) |
OK, I added a spec for the method (there wasn't one to begin with...) and an entry to the readme. Does it look good to you? |
Sorry, "added an entry to the changelog". |
Yeah, thanks |
Thank you, @theunraveler I'm not surprised the SVN implementation needed some work--I haven't used SVN in years and never used it via command line, so I'm not surprised there was a better way, and I'm quite grateful you were able to fix this so promptly. -- the author of #937 |
I also ran into this issue when deploying to a Ubuntu 14.04 server (GNU sed 4.2.2). I can confirm that this fix works nicely. Thanks a lot, @theunraveler! |
Any chance we'll see this merged soon? It looks like it's been approved for some time now and it would be great to be able to use the official gem rather than my patched local version. Thanks! |
Running into this problem as well, deploying to a CentOS 6.5 server with SVN repository. Understood that git is a new favor, somehow svn is still be heavily used in our projects. Just tested with this PR and it's working, can we have this PR merged soon? |
can you rebase this but us so it'll merge cleanly |
@theunraveler This was already fixed by another merged ticket, but your solution is IMO much more appropriate. I highly encourage you to rebase so that this can be merged. |
Alright, rebased against the current master. |
Use svnversion to capture svn revision number
@leehambley, any chance of getting this fix pushed out to a 3.2.2 version anytime soon? |
3.3 is pending me fixing the last failing cucumber features, i'm pressed on time as we have a newborn baby at home, and we're going through the motions of building our own house, but I'm doing my best :) watch us on twitter for the release announcement, it ought to be this week at any rate. |
Ah, no problem. Next week is cool. Congrats on the newborn, and good luck with the house! |
I was running into an issue with the sed part of the previous implementation (using GNU sed 4.2.1, from Debian Wheezy), so at first I set out to fix that issue. But then I discovered the svnversion command that ships with svn, and that seems to do the trick just as well.