Cucumber suite improvements #1049
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
May 9, 2014 12:26
Capistrano 'git:check' task executes a `git ls-remote -h #{repo_url}`
command to check if remote repo is accessible. If successful, command
output is a list of references and their SHAs.
Task should be successful and we're pretty sure remote repo will have a
`master` reference, so that's what we're asserting.
We're NOT asserting:
* repo references other than master - likely to change
* reference SHAs - will definitely change
'Checking linked files' scenarios were passing, but the steps were not defined at all. This commit defines the required steps.
When `deploy:symlink:linked_files` task is executed, only the release path (containing the timestamp) is created. After the task is done, it is hard to navigate over that release path (again, because it's a timestamp) to perform the assertions. To solve the issue, we're additionally creating a current path because the assertion is much more easily done via `current_path`.
|
@leehambley I think all 6 commits got merged by you manually - so this PR can be closed? |
|
Yep, I'm rebasing interactively the master history so that it's still clean. Thanks for the PR. I didn't want to disturb you with asking to rebase/squash/etc. |
|
Looks like these commits were merged in. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cucumber suite improvements. Also includes a contribution from #1033.
Some stats:
I tried to write detailed commit messages example to "preserve the knowledge" about how these scenarios work.
The contributing guidelines say we should squash the commits, but I have refrained from doing so because we would loose some of the info from the commit messages.
Other than that, I think I'm in compliance with the guidelines.