Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fallback ask to default when used in non interactive session #1972

Closed
wants to merge 1 commit into from
Closed

feat: fallback ask to default when used in non interactive session #1972

wants to merge 1 commit into from

Conversation

salzig
Copy link
Contributor

@salzig salzig commented Mar 28, 2018 •
edited

Summary

Maybe related/fixing: #1463

The intention of this code change is to fallback to the default value of ask when used in a non interactive session.

Short checklist

  • Did you run bundle exec rubocop -a to fix linter issues?
  • If relevant, did you create a test?
  • Did you confirm that the RSpec tests pass?
  • If you are fixing a bug or introducing a new feature, did you add a CHANGELOG entry?

@salzig salzig force-pushed the feat/fallback_ask_to_default_when_non_interactive branch 2 times, most recently from 6f1c320 to 8e95b27 Compare March 28, 2018 15:23
@salzig salzig force-pushed the feat/fallback_ask_to_default_when_non_interactive branch from 8e95b27 to 429d282 Compare April 3, 2018 14:43
@mattbrictson
Copy link
Member

This looks good! Nice to see test coverage as well. Thanks for the contribution, @salzig 🙌

@leehambley @will-in-wi any objections to merging this?

@mattbrictson
Copy link
Member

Merged as 3cff8cb

@mattbrictson
Copy link
Member

Congrats on your first contribution to the project! 🎉

This was referenced Jun 4, 2018
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@will-in-wi will-in-wi will-in-wi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@salzig @mattbrictson @will-in-wi