Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: run_locally now supports "echo: true" option. #285

Closed
wants to merge 2 commits into from
Closed

Feature: run_locally now supports "echo: true" option. #285

wants to merge 2 commits into from

Conversation

rdhallman
Copy link

I use run_locally to run acceptance tests before allowing a deploy. Problem is, run_locally doesn't echo the rspec commands running, so there is no output for 3 minutes while my tests are running. Would be much better if the "run_locally" command allowed real-time echo of my acceptance tests running so I can see what is going on. This commit adds such a "echo: true" option.

Now, my acceptance test task looks like this:

task :acceptance_test do
begin
run_locally "bundle exec rake spec", echo: true
rescue => ex
logger.important "Error: #{ex.message}"
end
if $? != 0
logger.important "Acceptance Tests FAILED! Aborting..."
exit
else
logger.info "Acceptance Tests PASSED."
end
end

@leehambley
Copy link
Member

Can you rebase this against master and I'll merge it in?

@leehambley leehambley closed this Apr 2, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants