Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No need to include capistrano gem when using capistrano-rails #15

Closed
wants to merge 1 commit into from
Closed

No need to include capistrano gem when using capistrano-rails #15

wants to merge 1 commit into from

Conversation

robinroestenburg
Copy link

Also see issue: capistrano/capistrano#582

When using capistrano-rails there is no need to include the capistrano gem. The only reason to include it is probably because you want to use a specific version.

Also see issue: capistrano/capistrano#582

When using capistrano-rails there is no need to include the capistrano gem. The only reason to include it is probably because you want to use a specific version.
@Kriechi
Copy link
Contributor

Kriechi commented Oct 9, 2013

👍

@kirs
Copy link
Member

kirs commented Oct 10, 2013

That's not verbose for me at all.
I'm using capistrano framework to deploy, not capistrano-rails.

With the same logic you should remove gem 'rails' from your Gemfile because some other gems are already dependent on Rails.

@Kriechi
Copy link
Contributor

Kriechi commented Oct 25, 2013

Mhm, on the same side one could argue that capistrano-rails should already include capistrano-bundler, since Rails3 and 4 use it by default.

@kirs though decision, should capistrano-rails be a one-stop-solution?
or more like a little tool to help build something bigger?

In the current capistrano-* universe I already have to include capistrano-rails, capistrano-bundler and capistrano-rvm gems... And capistrano itself of course.

@kirs
Copy link
Member

kirs commented Oct 26, 2013

I agree that it would be nice to add capistrano-bundler as dependency for capistrano-rails, but developers will still have to require it manually in Capfile.

@seenmyfate
Copy link
Member

I'm going to close this as this looks to be covered by #22

@seenmyfate seenmyfate closed this Oct 29, 2013
efornal pushed a commit to efornal/capistrano-svn that referenced this pull request Dec 19, 2013
This removes the need to set `require: false` in your Gemfile. Should
prevent the issues described in #582 reoccurring.

(also capistrano/rails#15)
mikejohn857 added a commit to mikejohn857/angular-capistrano-project that referenced this pull request Nov 25, 2022
This removes the need to set `require: false` in your Gemfile. Should
prevent the issues described in #582 reoccurring.

(also capistrano/rails#15)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants