No need to include capistrano gem when using capistrano-rails #15

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants

Also see issue: capistrano/capistrano#582

When using capistrano-rails there is no need to include the capistrano gem. The only reason to include it is probably because you want to use a specific version.

@robinroestenburg robinroestenburg No need to include capistrano gem when using capistrano-rails
Also see issue: capistrano/capistrano#582

When using capistrano-rails there is no need to include the capistrano gem. The only reason to include it is probably because you want to use a specific version.
872c43e

seenmyfate referenced this pull request in capistrano/capistrano Sep 13, 2013

Merged

Move requires to `capistrano/all` #649

Contributor

Kriechi commented Oct 9, 2013

👍

Owner

kirs commented Oct 10, 2013

That's not verbose for me at all.
I'm using capistrano framework to deploy, not capistrano-rails.

With the same logic you should remove gem 'rails' from your Gemfile because some other gems are already dependent on Rails.

Contributor

Kriechi commented Oct 25, 2013

Mhm, on the same side one could argue that capistrano-rails should already include capistrano-bundler, since Rails3 and 4 use it by default.

@kirs though decision, should capistrano-rails be a one-stop-solution?
or more like a little tool to help build something bigger?

In the current capistrano-* universe I already have to include capistrano-rails, capistrano-bundler and capistrano-rvm gems... And capistrano itself of course.

Owner

kirs commented Oct 26, 2013

I agree that it would be nice to add capistrano-bundler as dependency for capistrano-rails, but developers will still have to require it manually in Capfile.

Owner

seenmyfate commented Oct 29, 2013

I'm going to close this as this looks to be covered by #22

seenmyfate closed this Oct 29, 2013

@efornal efornal pushed a commit to efornal/capistrano-svn that referenced this pull request Dec 19, 2013

@seenmyfate seenmyfate Move requires to `capistrano/all`
This removes the need to set `require: false` in your Gemfile. Should
prevent the issues described in #582 reoccurring.

(also capistrano/rails#15)
447e4ce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment