Don't link public/assets if public is linked #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jboler can you test this branch and let me know if it solves the problem for you? Thanks! |
If the user has already added "public" to Capistrano's `:linked_dirs`, then further linking "public/assets" is not only unnecessary, it causes conflicts and asset precompilation fails as a result. Fix this by checking if "public" is already linked, and if so, skip linking "public/assets".
mattbrictson
force-pushed
the
avoid-double-symlink-of-public
branch
from
009b20f
to
3203981
Compare
|
@mattbrictson Yup - that works - thanks! |
|
Thanks for testing! I'll merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user has already added "public" to Capistrano's
:linked_dirs, then further linking "public/assets" is not only unnecessary, it causes conflicts and asset precompilation fails as a result.Fix this by checking if "public" is already linked, and if so, skip linking "public/assets".
Fixes #151.