-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate using SSHKit prefixes #14
Conversation
end | ||
|
||
before 'deploy:starting', 'rbenv:check' | ||
before 'deploy:starting', 'rbenv:map_bins' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leehambley I see the problem here: rbenv:map_bins
will be executed only in the deploy cycle. If I run cap staging unicorn:reload
these tasks will not be loaded 😕
Any ideas?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about adding something like this to the rvm/rbenv hooks:
Rake::Task.tasks.each do |t|
t.enhance do
[...]
end
end
and then adding the hook as dependency/prerequisite or so...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found another solution suggested by @leafac:
https://github.com/leafac/rbenv/commit/0ce9691578b7fbb4174ce0ae31e6d89c1678c09b#diff-f35b3df388b0c01ad40bb85555fc900cR11
What do you think about it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wish comment discussions didn't exist. I can't work this way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess you are talking about this:
Capistrano::DSL.stages.each do |stage|
after stage, :'rbenv:command_map'
end
Looks good too me - if it's working.
Here is the first implementation using SSHKit prefixes: capistrano/sshkit#45