Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate using SSHKit prefixes #14

Merged
merged 4 commits into from
Nov 23, 2013
Merged

Integrate using SSHKit prefixes #14

merged 4 commits into from
Nov 23, 2013

Conversation

kirs
Copy link
Member

@kirs kirs commented Nov 19, 2013

Here is the first implementation using SSHKit prefixes: capistrano/sshkit#45

end

before 'deploy:starting', 'rbenv:check'
before 'deploy:starting', 'rbenv:map_bins'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leehambley I see the problem here: rbenv:map_bins will be executed only in the deploy cycle. If I run cap staging unicorn:reload these tasks will not be loaded 😕

Any ideas?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about adding something like this to the rvm/rbenv hooks:

Rake::Task.tasks.each do |t| 
  t.enhance do 
    [...]
  end
end

and then adding the hook as dependency/prerequisite or so...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish comment discussions didn't exist. I can't work this way.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😆

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you are talking about this:

Capistrano::DSL.stages.each do |stage|
  after stage, :'rbenv:command_map'
end

Looks good too me - if it's working.

kirs added a commit that referenced this pull request Nov 23, 2013
Integrate using SSHKit prefixes
@kirs kirs merged commit 67bfa00 into master Nov 23, 2013
@kirs kirs deleted the sshkit-bins branch November 23, 2013 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants