Skip to content

Commit

Permalink
Simplify SSHKit::Runner::ExecuteError
Browse files Browse the repository at this point in the history
Remove backtrace() and backtrace_locations() overrides from
ExecuteError.  Having this interferes with rake default behaviour for
displaying exceptions with causes and creates duplicate and
unnecessarily verbose stacktraces in Capistrano.
  • Loading branch information
townsen committed Feb 19, 2015
1 parent 1b2b2db commit f04d2c6
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 8 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Expand Up @@ -13,6 +13,8 @@ appear at the top.
were ignored.
* Fixed race condition where output of failed command would be empty. @townsen
Caused random failures of `test_execute_raises_on_non_zero_exit_status_and_captures_stdout_and_stderr`
* Remove override of backtrace() and backtrace_locations() from ExecuteError. @townsen
This interferes with rake default behaviour and creates duplicate stacktraces.

## 1.6.0

Expand Down
8 changes: 0 additions & 8 deletions lib/sshkit/exception.rb
Expand Up @@ -8,14 +8,6 @@ class ExecuteError < StandardError
def initialize cause
@cause = cause
end

def backtrace
@cause.backtrace
end

def backtrace_locations
@cause.backtrace_locations
end
end
end
end

0 comments on commit f04d2c6

Please sign in to comment.