Specify colorize version dependency

[Confusion]

Current sshkit depends on colorize 0.6.0+, because it expects it has defined the Color.bold method, which only happens if colorize defines the bold mode, which wasn't the case in versions before 0.6.0.

If you are using an older colorize, you will get

Exception while executing on host 127.0.0.1: undefined method `bold' for Color:Module
$PROJECT_ROOT/vendor/bundle/ruby/2.0.0/gems/sshkit-1.5.1/lib/sshkit/formatters/pretty.rb:22:in `write_command'

[mattjmorrison]

👍 as of Colorize 0.7.5 the API changed and String::COLORS no longer exists.

[kalys]

@mattjmorrison I cannot work with capistrano because of this.

[baires]

Same here

[leehambley]

If someone can report a last known good version, I'll lock the gem dependency. Similar issue on Capistrano reported ~20 mins ago (now closed) capistrano/capistrano#1228

[kalys]

0.7.4 is ok.

[sponomarev]

@leehambley 0.7.3 is good enough

[leehambley]

Seems to have been changed in fazibear/colorize@7cba4a1#diff-f8d8a85a7e89db8ca4c5dbfd9944ccc8R25, man their CHANGELOG is a mess...

Workaround for now, you can lock that dependency additional next to SSHKit, a Real fix for SSHKit is tricky as we try really hard not to lock dependencies on Rake, and other "likely to be required from other gems" deps, so that if we are slow in updating our locked gems, then we don't break other projects, I think the correct fix for this might be to switch on the Colorize::Version and try both APIs to avoid locking one specific range.

I can't believe they've completely changed their API in a "feature" release, seems a bit overkill and like what I might interpret to be a violation of my understanding of semver.

If someone can send a PR, I'd be very appreciative, otherwise I'll likely get to fixing it before the 20th, but not before.

[sponomarev]

@leehambley Is it nice to change sshkit to accept new colorize API?

[leehambley]

The problem is that I really hate when tools which aren't part of your apps dependencies (like Cap, and SSHKit, by proxy) are forcing hard gem dependencies, what if you have some logger in your app, which locks colorize ~> 0.6.0, and you want to use Cap as well… then you have to choose between dev time and production time dependencies because of the way Bundler works, and I really try hard to avoid forcing that on people.

If a short term solution is to make a harder gem requirement on a known good older version of colorize, fair enough, it might stop disappointing new users who have a clean gemset.

But in the end, I'd like to support both APIs, and not force users into using one, or the other version of the colorize gem, and by proxy it's API.

[fazibear]

Why you don'y use String.colors and String.modes methods. It's part of API. It's the same across all colorize versions. Besides it gives you just color and mode names.
#199

[leehambley]

Seems like colorize don't bother to document their API, if you can send a PR to replace the one #198 I just merged, I'd be glad of it... I don't care how we get it fixed, as long as we do. 1.6.0 fixed the version dep on 0.6x as a stop-gap.

[fazibear]

This is from README:

String.colors - return array of all possible colors names
String.modes - return array of all possible modes

And this is PR that use this methods: #199