Use colorize dedicated method for color and modes #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks we have a cross-compatible API in another PR. |
leehambley
added a commit
that referenced
this pull request
Dec 16, 2014
Use colorize dedicated method for color and modes
|
Thanks, so I've merged two PRs fixing the same thing, so I'll clean this up tomorrow. Fix the version dependency, and get a new release out. Expect 1.6.1 in the next ~12 hrs or so. |
|
This fails old colorize API |
|
Seems like Colourize can't really be said in any strong way to have an API... |
|
Yes))) but you wanted to support both versions) my first suggestion was to upgrade sshkit to fit latest colorize... |
|
Indeed, this fixes it well enough, and all 0.7 series covers the last two years - http://rubygems.org/gems/colorize/versions |
|
Thanks for support, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, colorize gem provides dedicated methods to list all modes and colors.
This merge request fix this problem.