Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSHKit::Configuration.format doesn't pick up on "BlackHole" #74

Closed
hab278 opened this issue Dec 12, 2013 · 3 comments · Fixed by #76
Closed

SSHKit::Configuration.format doesn't pick up on "BlackHole" #74

hab278 opened this issue Dec 12, 2013 · 3 comments · Fixed by #76

Comments

@hab278
Copy link
Contributor

hab278 commented Dec 12, 2013

Gives the following error.

uninitialized constant SSHKit::Formatter::Blackhole
/sshkit/lib/sshkit/configuration.rb:47:in `const_get'
/sshkit/lib/sshkit/configuration.rb:47:in `formatter'
/sshkit/lib/sshkit/configuration.rb:29:in `format='
@hab278
Copy link
Contributor Author

hab278 commented Dec 12, 2013

Looks like it's this line

SSHKit::Formatter.const_get(format.capitalize).new($stdout)

This capitalizes the first letter and lowercases the rest. BlackHole gets converted to Blackhole.

@leehambley
Copy link
Member

Can you send a patch?

Lee Hambley

http://lee.hambley.name/
+49 (0) 170 298 5667

On 12 December 2013 18:59, hab278 notifications@github.com wrote:

Looks like it's this linehttps://github.com/capistrano/sshkit/blob/master/lib/sshkit/configuration.rb#L47

SSHKit::Formatter.const_get(format.capitalize).new($stdout)

This capitalizes the first letter and lowercases the resthttp://www.ruby-doc.org/core-1.9.2/String.html#method-i-capitalize.
BlackHole gets converted to Blackhole.


Reply to this email directly or view it on GitHubhttps://github.com//issues/74#issuecomment-30445821
.

@hab278
Copy link
Contributor Author

hab278 commented Dec 12, 2013

@leehambley Coming right up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants