Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow silencing upload/download #456

Closed
grosser opened this issue Mar 1, 2019 · 2 comments · Fixed by #468
Closed

allow silencing upload/download #456

grosser opened this issue Mar 1, 2019 · 2 comments · Fixed by #468

Comments

@grosser
Copy link
Contributor

grosser commented Mar 1, 2019

would be great if I could pass verbose: false or so to these to make things a little less noisy ... atm I'm using a global silence which is not threadsafe ...

  def silence_sshkit
    old = SSHKit.config.output_verbosity
    SSHKit.config.output_verbosity = :WARN
    yield
  ensure
    SSHKit.config.output_verbosity = old
  end
@will-in-wi
Copy link
Contributor

That would make sense to me. Would you be willing to attempt a patch?

@grosser
Copy link
Contributor Author

grosser commented May 31, 2019

I'll take a look

@grosser grosser mentioned this issue Jul 8, 2019
Merged
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this issue Nov 18, 2019
security/ruby-sshkit: update to 1.20.0
c2dfff1 
Update ruby-sshkit package to 1.20.0.


## [1.20.0][] (2019-08-03)

  * [#468](capistrano/sshkit#468): Make `upload!` take a `:verbosity` option like `exec` does - [@grosser](https://github.com/grosser)

## [1.19.1][] (2019-07-02)

  * [#465](capistrano/sshkit#456): Fix a regression in 1.19.0 that prevented `~` from being used in Capistrano paths, e.g. `:deploy_to`, etc. - [@grosser](https://github.com/grosser)

## [1.19.0][] (2019-06-30)

  * [#455](capistrano/sshkit#455): Ensure UUID of commands are stable in logging - [@lazyatom](https://github.com/lazyatom)
  * [#453](capistrano/sshkit#453): `as` and `within` now properly escape their user/group/path arguments, and the command nested within an `as` block is now properly escaped before passing to `sh -c`. In the unlikely case that you were manually escaping commands passed to SSHKit as a workaround, you will no longer need to do this. See [#458](capistrano/sshkit#458) for examples of what has been fixed. - [@grosser](https://github.com/grosser)
  * [#460](capistrano/sshkit#460): Handle IPv6 addresses without port - [@will-in-wi](https://github.com/will-in-wi)

## [1.18.2][] (2019-02-03)

  * [#448](capistrano/sshkit#448): Fix misbehaving connection eviction loop when disabling connection pooling - [Sebastian Cohnen](https://github.com/tisba)

## [1.18.1][] (2019-01-26)

  * [#447](capistrano/sshkit#447): Fix broken thread safety by widening critical section - [Takumasa Ochi](https://github.com/aeroastro)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add a runnable example and document how verbosity/silence works grosser/sshkit
2 participants
@grosser @will-in-wi