Skip to content

Commit

Permalink
add wavesets notebooks
Browse files Browse the repository at this point in the history
  • Loading branch information
telephon committed Oct 26, 2021
1 parent 7c26fe4 commit aafbaa3
Show file tree
Hide file tree
Showing 7 changed files with 1,521 additions and 63 deletions.
3 changes: 2 additions & 1 deletion 00_basics/machine_learning.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -1700,7 +1700,8 @@
"mimetype": "text/x-python",
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3"
"pygments_lexer": "ipython3",
"version": "3.8.12"
}
},
"nbformat": 4,
Expand Down
3 changes: 2 additions & 1 deletion 00_basics/py_dimensions.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -732,7 +732,8 @@
"mimetype": "text/x-python",
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3"
"pygments_lexer": "ipython3",
"version": "3.8.9"
}
},
"nbformat": 4,
Expand Down
3 changes: 2 additions & 1 deletion 01_midi_drums/01_midi_drums.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -4495,7 +4495,8 @@
"mimetype": "text/x-python",
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3"
"pygments_lexer": "ipython3",
"version": "3.8.12"
}
},
"nbformat": 4,
Expand Down
590 changes: 531 additions & 59 deletions 01_spect_resynth/02_spect.ipynb

Large diffs are not rendered by default.

3 changes: 2 additions & 1 deletion 01_spect_resynth/03_nmf.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -902,7 +902,8 @@
"mimetype": "text/x-python",
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3"
"pygments_lexer": "ipython3",
"version": "3.8.9"
}
},
"nbformat": 4,
Expand Down
244 changes: 244 additions & 0 deletions 01_spect_resynth/wavesets.ipynb

Large diffs are not rendered by default.

Loading

5 comments on commit aafbaa3

@capital-G
Copy link
Owner

@capital-G capital-G commented on aafbaa3 Nov 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit introduced lots of files that should not be in this repo, like wavesets.ipynb and wavesets2.ipynb and the same time i have the feeling that pre-commit did not check the commit properly as there are some artifacts like version in some notebook, at the same time the changes are so big I can not view them in github.
I really would like to revert this commit as it introduces lots of stuff that just spams the history and re-introduce it properly.

Also it introduced notebooks that are not linked in the jupyter book which should always be the case. I really do not know how to fix this properly now as it is difficult to change the git history if you have some non native-git people following this repo.

@capital-G
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After some verification in the other commit it turns out those commits were not sanitized by pre-commit (see e.g. 1527729#diff-6ce41010093e27eb6bc6db5955ee4be88ebaa0316b606cdbd4d4f5c7345bf9f9R29 - a thing that pre-commit deletes in order to avoid merge conflicts in notebooks).

@telephon please make sure you have set up pre-commit as described in https://capital-g.github.io/musikinformatik-sose2021/docs/course-info/contribute.html#pre-commit - maybe I will add a rejection mechanism as github action if pre-commit check fails but this is also difficult :/

@telephon
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thanks for the hint. I had completely forgotten that there was an extra step to be followed.

@capital-G
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it is a bit hard at the beginning. working with notebooks and repos is always a struggle. even saw some 200mb commits back in the old days which resulted in multiple GB repos :D

@telephon
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.