-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
7 changed files
with
1,521 additions
and
63 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Oops, something went wrong.
aafbaa3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commit introduced lots of files that should not be in this repo, like
wavesets.ipynb
andwavesets2.ipynb
and the same time i have the feeling thatpre-commit
did not check the commit properly as there are some artifacts likeversion
in some notebook, at the same time the changes are so big I can not view them in github.I really would like to revert this commit as it introduces lots of stuff that just spams the history and re-introduce it properly.
Also it introduced notebooks that are not linked in the jupyter book which should always be the case. I really do not know how to fix this properly now as it is difficult to change the git history if you have some non native-git people following this repo.
aafbaa3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After some verification in the other commit it turns out those commits were not sanitized by pre-commit (see e.g. 1527729#diff-6ce41010093e27eb6bc6db5955ee4be88ebaa0316b606cdbd4d4f5c7345bf9f9R29 - a thing that pre-commit deletes in order to avoid merge conflicts in notebooks).
@telephon please make sure you have set up pre-commit as described in https://capital-g.github.io/musikinformatik-sose2021/docs/course-info/contribute.html#pre-commit - maybe I will add a rejection mechanism as github action if pre-commit check fails but this is also difficult :/
aafbaa3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, thanks for the hint. I had completely forgotten that there was an extra step to be followed.
aafbaa3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it is a bit hard at the beginning. working with notebooks and repos is always a struggle. even saw some 200mb commits back in the old days which resulted in multiple GB repos :D
aafbaa3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/nextjournal/clerk