Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement proper env handling for frontend #3

Closed
capital-G opened this issue Apr 2, 2022 · 1 comment
Closed

Implement proper env handling for frontend #3

capital-G opened this issue Apr 2, 2022 · 1 comment
Assignees
@capital-G
Labels
bug Something isn't working

Comments

@capital-G
Copy link
Owner

Frontend relies on VUE_APP_SOCKET_ENDPOINT which is declared in gitignored ./frontend/.venv - should be handeled better, also consider this for static build
@capital-G capital-G added the bug Something isn't working label Apr 2, 2022
@capital-G capital-G self-assigned this Apr 2, 2022
capital-G added a commit that referenced this issue Apr 3, 2022
@capital-G
Implement proper env handling for frontend #3
5bb731b
@capital-G
Copy link
Owner Author

It seems it is impossible to hand env variables to vue in runtime, only via a env file which is a bit of a bummer.
Maybe using something like export > .env to pass env variables? But closed for now as we simply copy the host for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@capital-G capital-G

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@capital-G