docs: add contributor notes on where to find documentation branches #1113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taylorfturner
requested changes
Mar 12, 2024
.github/CONTRIBUTING.md
Outdated
| @@ -106,3 +106,6 @@ the documentation. | |||
|
|
|||
| ## Updating Dependencies | |||
| If you make changes to the `requirements` text files, please also update the `additional_dependencies` list under the `mypy` hook in `.pre-commit-config.yaml`. This is necessary for accurate type-checking. | |||
|
|
|||
| ## Contributing Documentation Changes and Fixes | |||
| Please see the `gh-pages` and `dev-gh-pages` branches for all documentation. | |||
There was a problem hiding this comment.
Technically a PR for updating the documentation should only go into dev-gh-pages -- and when we do a release a PR will be opened to gh-pages. Follow-up clarity worthwhile for this new section
There was a problem hiding this comment.
Good idea on clarification, see 5e36e17
There was a problem hiding this comment.
looking good @carlsonp
taylorfturner
previously approved these changes
Mar 12, 2024
There was a problem hiding this comment.
LGTM -- small comment for follow-up PR. Thanks for the contribution @carlsonp
auto-merge was automatically disabled
March 12, 2024 19:17
Head branch was pushed to by a user without write access
taylorfturner
requested changes
Mar 12, 2024
|
Seeing a test error: |
|
@carlsonp you should be good to rebase onto |
…d `gh-pages` branches exist for staging content
Co-authored-by: Taylor Turner <taylorfturner@gmail.com>
carlsonp
force-pushed
the
contributor-docs-note
branch
from
6fb1f3e
to
8d3d8a2
Compare
|
Rebased |
auto-merge was automatically disabled
March 27, 2024 22:35
Head branch was pushed to by a user without write access
Co-authored-by: Taylor Turner <taylorfturner@gmail.com>
ksneab7
approved these changes
Apr 8, 2024
abajpai15
pushed a commit
to abajpai15/DataProfiler
that referenced
this pull request
Apr 15, 2024
…apitalone#1113) * docs: add contributor notes on where to find documentation branches * docs: update documentation wording to spell out why `dev-gh-pages` and `gh-pages` branches exist for staging content * docs: add note on fork Co-authored-by: Taylor Turner <taylorfturner@gmail.com> * Update .github/CONTRIBUTING.md Co-authored-by: Taylor Turner <taylorfturner@gmail.com> --------- Co-authored-by: Taylor Turner <taylorfturner@gmail.com>
micdavis
pushed a commit
that referenced
this pull request
May 20, 2024
* Replace snappy with cramjam (#1091) * add downloads tile (#1085) * Replace snappy with cramjam * Delete test_no_snappy --------- Co-authored-by: Taylor Turner <taylorfturner@gmail.com> * Quick fix for dependency max pins (#1120) * Fix dask_expr * Keras and Tensorflow version fix * Keras and Tensorflow version fix * Fix keras bug * pre-commit fix (#1122) * docs: update test link to latest version (#1114) * docs: add contributor notes on where to find documentation branches (#1113) * docs: add contributor notes on where to find documentation branches * docs: update documentation wording to spell out why `dev-gh-pages` and `gh-pages` branches exist for staging content * docs: add note on fork Co-authored-by: Taylor Turner <taylorfturner@gmail.com> * Update .github/CONTRIBUTING.md Co-authored-by: Taylor Turner <taylorfturner@gmail.com> --------- Co-authored-by: Taylor Turner <taylorfturner@gmail.com> * update black version (#1131) * Add memray max version (#1132) * Bug fix for float precision calculation using categorical data with trailing zeros. (#1125) * Revert "Bug fix for float precision calculation using categorical data with t…" (#1133) This reverts commit d3159bd. * fix * make up to date * yep, shouldn't change * bump version --------- Co-authored-by: Gábor Lipták <gliptak@gmail.com> Co-authored-by: abajpai15 <73404357+abajpai15@users.noreply.github.com> Co-authored-by: Patrick Carlson <carlson2442@gmail.com> Co-authored-by: James Schadt <jamesrschadt@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.