Add Python 3.9 to GHA #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gliptak
requested review from
ChrisWallace2020,
grant-eden,
JGSweets,
ksneab7 and
taylorfturner
as code owners
JGSweets
reviewed
Feb 8, 2022
|
@gliptak Seems like py3.10 has an issue installing python-snappy? |
|
Seems like an error changed text between py38 to py39 which is causing the error. If we update the test to agnostic to py version, it should work. |
Signed-off-by: Gábor Lipták <gliptak@gmail.com>
|
I think the error lies in the test: Need to catch the case where method becomes methods between versions. |
JGSweets
approved these changes
Feb 10, 2022
stevensecreti
pushed a commit
to stevensecreti/DataProfiler
that referenced
this pull request
Jun 15, 2022
Signed-off-by: Gábor Lipták <gliptak@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gábor Lipták gliptak@gmail.com