DateTimeColumn: Handle Datetime day suffixes #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on.dumps() functionality. Updated numerical_column_stats.py _perform_t_test to cast conservative and welch values to floats before assignment.
micdavis
requested review from
JGSweets,
grant-eden,
ChrisWallace2020,
ksneab7 and
taylorfturner
as code owners
micdavis
commented
Apr 11, 2022
micdavis
commented
Apr 11, 2022
JGSweets
reviewed
Apr 11, 2022
JGSweets
reviewed
Apr 11, 2022
JGSweets
reviewed
Apr 11, 2022
JGSweets
reviewed
Apr 12, 2022
JGSweets
reviewed
Apr 12, 2022
|
@micdavis , run |
JGSweets
previously approved these changes
Apr 13, 2022
| @@ -268,6 +268,8 @@ def test_profile(self): | |||
| expected = defaultdict(float, {'datetime': 2.0}) | |||
| self.assertEqual(expected, profiler.profile['times']) | |||
|
|
|||
There was a problem hiding this comment.
nit pick but you can probably get rid of this extra space between the two self.assert in the same test function
JGSweets
approved these changes
Apr 13, 2022
taylorfturner
approved these changes
Apr 13, 2022
stevensecreti
pushed a commit
to stevensecreti/DataProfiler
that referenced
this pull request
Jun 15, 2022
* Fix: updated test_(int/float)_column_profile.py test_diff to cover json.dumps() functionality. Updated numerical_column_stats.py _perform_t_test to cast conservative and welch values to floats before assignment. * Fix: addressed PR change requests. * Fix: Reformatting * Fix: Added check to test to cover newly required functionality. * Bumped version * Fixed Datetime profiler day suffix issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Updated datetime_column_profile.py to remove day suffixes from the date when we check its format. Updated the test_datetime_column_profile.py test to test for this change. Addresses this issue #441