Add New preprocessor for using an encoding map #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JGSweets
requested review from
grant-eden,
ChrisWallace2020,
ksneab7 and
taylorfturner
as code owners
JGSweets
commented
Jul 5, 2022
Comment on lines
+752
to
+762
| char_processor_gen = super().process( | ||
| data, labels, label_mapping, batch_size) | ||
| encoding_map = self._parameters['encoding_map'] | ||
| max_length = self._parameters['max_length'] | ||
| for char_processed_data in char_processor_gen: | ||
| x = char_processed_data | ||
| if labels: | ||
| x = char_processed_data[0] | ||
| y = char_processed_data[1] | ||
|
|
||
| processed_x = np.zeros((len(x), max_length), dtype='int64') |
There was a problem hiding this comment.
uses the previous char generator and then just encodes it after.
taylorfturner
approved these changes
Jul 6, 2022
JGSweets
commented
Jul 6, 2022
Comment on lines
-1603
to
+1727
| aggregtation_func = parameters.get( | ||
| aggregation_func = parameters.get( | ||
| 'aggregation_func', | ||
| self._parameters.get('aggregation_func') | ||
| if hasattr(self, '_parameters') else None) | ||
| if value is None and aggregtation_func == 'priority': | ||
| if value is None and aggregation_func == 'priority': | ||
| errors.append( | ||
| '`{}` cannot be None if `aggregtation_func` == ' | ||
| '`{}` cannot be None if `aggregation_func` == ' |
taylorfturner
approved these changes
Jul 6, 2022
micdavis
approved these changes
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows a user to set the encoding map to be used in the preprocesor