Add data labeler tf loader for any cnn softmax model #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JGSweets
added
Medium Priority
JGSweets
requested review from
ksneab7,
taylorfturner,
micdavis and
tyfarnan
as code owners
JGSweets
commented
Jul 12, 2022
| @@ -17,237 +16,7 @@ | |||
| _file_dir = os.path.dirname(os.path.abspath(__file__)) | |||
|
|
|||
| logger = dp_logging.get_child_logger(__name__) | |||
|
|
|||
There was a problem hiding this comment.
moved to labeler_utils.py
JGSweets
commented
Jul 12, 2022
| @@ -0,0 +1,148 @@ | |||
| import json | |||
There was a problem hiding this comment.
new test for new labeler
JGSweets
commented
Jul 12, 2022
| @@ -0,0 +1,373 @@ | |||
| import json | |||
There was a problem hiding this comment.
new test for new model
JGSweets
commented
Jul 12, 2022
| @@ -22,7 +22,7 @@ | |||
| import numpy as np | |||
| import tensorflow as tf | |||
|
|
|||
| from dataprofiler.labelers.character_level_cnn_model import F1Score, FBetaScore | |||
| from dataprofiler.labelers.labeler_utils import F1Score, FBetaScore | |||
There was a problem hiding this comment.
updated for movement
JGSweets
commented
Jul 12, 2022
| @@ -267,3 +269,33 @@ def test_save_conf_mat(self, mock_dataframe): | |||
| self.assertDictEqual(expected_row_col_names, mock_dataframe.call_args[1]) | |||
|
|
|||
| mock_instance_df.to_csv.assert_called() | |||
|
|
|||
|
|
|||
| class TestTFFunctions(unittest.TestCase): | |||
There was a problem hiding this comment.
test new get layer name func
JGSweets
commented
Jul 12, 2022
| ind = labeler_utils.get_tf_layer_index_from_name(model, 'dense0') | ||
| self.assertEqual(0, ind) | ||
|
|
||
| def test_hide_tf_logger_warnings(self): |
There was a problem hiding this comment.
test ability for func to hide logs
JGSweets
commented
Jul 12, 2022
| @@ -0,0 +1,511 @@ | |||
| import json | |||
micdavis
reviewed
Jul 13, 2022
|
|
||
| # Make sure the necessary parameters are present and valid. | ||
| for param in parameters: | ||
| if param in ["default_label", "model_path", "pad_label"]: |
There was a problem hiding this comment.
Suggested change
| if param in ["default_label", "model_path", "pad_label"]: | |
| if param in list_of_necessary_params: |
There was a problem hiding this comment.
fair, not usually the case, but works for this one since they are all strings
There was a problem hiding this comment.
I have slight concerns this makes it less clear as it doesn't list the values at the point of callout, but I'm fine switching it.
taylorfturner
previously approved these changes
Jul 13, 2022
taylorfturner
approved these changes
Jul 13, 2022
micdavis
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the DL to load any TF model which has a softmax output