HOT FIX: update README and remove isort.cfg #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taylorfturner
added
Bug
taylorfturner
requested review from
JGSweets,
ksneab7,
micdavis and
tyfarnan
as code owners
taylorfturner
commented
Jul 13, 2022
| @@ -1,4 +0,0 @@ | |||
| [settings] | |||
There was a problem hiding this comment.
now in setup.cfg
taylorfturner
commented
Jul 13, 2022
| @@ -42,6 +42,7 @@ If the ML requirements are too strict (say, you don't want to install tensorflow | |||
|
|
|||
| Install from pypi: `pip install DataProfiler` | |||
|
|
|||
| If you want to install the dependencies for developing and updating the code base, be sure to run `pip install -r requirements-dev.txt` | |||
There was a problem hiding this comment.
clarity in the README for installing additional dependencies when working on the repo
micdavis
approved these changes
Jul 13, 2022
tyfarnan
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isort.cfg. Setting now moved tosetup.cfgrequirements-dev.txt