[UTILs] Adding top-level function for distributed merging of profiles #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m/taylorfturner/DataProfiler into feature/distributed_profile_merge
taylorfturner
added
Bug
taylorfturner
requested review from
JGSweets,
ksneab7,
micdavis and
tyfarnan
as code owners
…m/taylorfturner/DataProfiler into feature/distributed_profile_merge
taylorfturner
commented
Jul 22, 2022
Comment on lines
-49
to
-65
| self.reverse_label_mapping = self.data_labeler.reverse_label_mapping | ||
| num_labels = self.data_labeler.model.num_labels | ||
|
|
||
| # remove PAD from output (reserved zero index) | ||
| if self.data_labeler.model.requires_zero_mapping: | ||
| self.reverse_label_mapping.pop(0, None) | ||
| num_labels -= 1 | ||
|
|
||
| self._possible_data_labels = list(self.reverse_label_mapping.values()) | ||
| self._possible_data_labels = [ # sort the data_labels based on index | ||
| x | ||
| for _, x in sorted( | ||
| zip(self.reverse_label_mapping.keys(), self._possible_data_labels) | ||
| ) | ||
| ] | ||
| self.rank_distribution = dict([(key, 0) for key in self._possible_data_labels]) | ||
| self._sum_predictions = np.zeros(num_labels) |
There was a problem hiding this comment.
Moving these to _update_predictions so they are not created on __init__
taylorfturner
commented
Jul 22, 2022
| @@ -865,7 +866,7 @@ def update_profile(self, data, sample_size=None, min_true_samples=None): | |||
| if file_type is not None: | |||
| self.file_type = file_type | |||
|
|
|||
| def _remove_data_labelers(self): | |||
| def _remove_data_labelers(self, replacement_type=BaseDataLabeler()): | |||
There was a problem hiding this comment.
moving this instantiation to the actual function definitions BaseDataLabeler
taylorfturner
commented
Jul 22, 2022
| @@ -21,6 +21,7 @@ | |||
|
|
|||
| from .. import data_readers, dp_logging | |||
| from ..labelers.data_labelers import DataLabeler | |||
| from ..labelers.base_data_labeler import BaseDataLabeler | |||
There was a problem hiding this comment.
adding this import so the code can set the replacement_type for when _restore_data_labelers is called on a profile object
JGSweets
approved these changes
Jul 22, 2022
ksneab7
approved these changes
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
list--> into a singleProfilethat is the merging of all the profilesStructuredProfilermerge operation