Reformatted batch 2 (see comment) with flake8. #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakleh
requested review from
JGSweets,
ksneab7,
taylorfturner,
micdavis and
tyfarnan
as code owners
JGSweets
reviewed
Jul 26, 2022
dataprofiler/labelers/base_model.py
Outdated
Comment on lines
126
to
128
| # Import possible internal models | ||
| from .character_level_cnn_model import CharacterLevelCnnModel | ||
| from .regex_model import RegexModel |
There was a problem hiding this comment.
this actually might be critical and cause issues if not included due to the way the auto import works. Scenario dependent. I'm not 100% sure tests will capture.
There was a problem hiding this comment.
Could put a comment flag to ignore.
JGSweets
approved these changes
Jul 26, 2022
taylorfturner
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Files reformatted:
-dataprofiler/labelers/base_model.py
-dataprofiler/profilers/base_column_profilers.py
-dataprofiler/settings.py
-dataprofiler/data_readers/csv_data.py
-dataprofiler/data_readers/structured_mixins.py
-dataprofiler/data_readers/avro_data.py
-dataprofiler/data_readers/parquet_data.py
-dataprofiler/data_readers/text_data.py
-dataprofiler/reports/init.py