Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes profile_schema bug for unnamed columns #612

Merged
merged 1 commit into from
Aug 15, 2022
Merged

fixes profile_schema bug for unnamed columns #612

merged 1 commit into from
Aug 15, 2022

Conversation

JGSweets
Copy link
Collaborator

Address the bug when running:

import json

import dataprofiler as dp


data = dp.Data("./dataprofiler/tests/data/csv/iris_no_header.csv")
profiler = dp.Profiler(data)
readable_report = profiler.report(report_options={"output_format": "serializable"})
json.dumps(readable_report)

From tangential issue to:
#442

@JGSweets JGSweets added Bug Something isn't working High Priority Dramatic improvement, inaccurate calculation(s) or bug / feature making the library unusable labels Aug 12, 2022
@taylorfturner taylorfturner enabled auto-merge (squash) August 12, 2022 21:26
taylorfturner
taylorfturner approved these changes Aug 12, 2022
View reviewed changes
Copy link
Contributor

@taylorfturner taylorfturner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taylorfturner taylorfturner merged commit 4f3f975 into capitalone:main Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taylorfturner taylorfturner taylorfturner approved these changes

@ksneab7 ksneab7 ksneab7 approved these changes

@micdavis micdavis Awaiting requested review from micdavis

@tyfarnan tyfarnan Awaiting requested review from tyfarnan

Assignees

@taylorfturner taylorfturner

Labels
Bug Something isn't working High Priority Dramatic improvement, inaccurate calculation(s) or bug / feature making the library unusable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JGSweets @taylorfturner @ksneab7