refactor: validate parameters and the returns of functions #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanycoimbra
requested review from
JGSweets,
ksneab7,
taylorfturner,
micdavis and
tyfarnan
as code owners
|
|
JGSweets
reviewed
Sep 17, 2022
auto-merge was automatically disabled
September 17, 2022 00:17
Head branch was pushed to by a user without write access
JGSweets
approved these changes
Sep 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Imports additions to validate the types of functions' parameters and its returns using mypy:
Line 4: from typing import List, Callable, TypeVar, cast, Any
Line 5: from typing import NoReturn
Initialize the generic type to use with decorators:
Line 8: F = TypeVar('F', bound=Callable[..., Any])
Other changes:
Line 11: add the "NoReturn" for the function warn_missing_module()
Lines 30 and 41: add the return type as F (generic type)
Lines 55 and 57: add the cast to using decorators with wrappers (see in https://mypy.readthedocs.io/en/stable/generics.html#declaring-decorators)