Static Typing profilers/profiler_options.py #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonywu315
requested review from
JGSweets,
ksneab7,
taylorfturner,
micdavis and
tyfarnan
as code owners
JGSweets
reviewed
Sep 19, 2022
| @@ -1,9 +1,12 @@ | |||
| #!/usr/bin/env python | |||
| """Specify the options when running the data profiler.""" | |||
| from __future__ import annotations | |||
There was a problem hiding this comment.
On line 36, I added
if TYPE_CHECKING:
from .profile_builder import BaseProfiler
because BaseProfiler has a circular dependency with utils. Adding this means that I need to postpone the evaluation of type annotations, since BaseProfiler is not defined until later. In Python 3.7, this can be done by importing annotations from __future__ or by using "BaseProfiler" instead of BaseProfiler for types.
There was a problem hiding this comment.
Oh I thought this was for the utils PR. For this one, it's because the class types aren't defined until later. PEP 563
|
@tonywu315 FYI, I think your code is out of date. You will likely need to rebase this branch onto |
1 similar comment
|
@tonywu315 FYI, I think your code is out of date. You will likely need to rebase this branch onto |
JGSweets
approved these changes
Sep 20, 2022
ksneab7
approved these changes
Sep 20, 2022
micdavis
approved these changes
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.