ColumnNameLabeler Notebook Example #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taylorfturner
added
Documentation
taylorfturner
requested review from
JGSweets,
ksneab7,
micdavis and
tyfarnan
as code owners
taylorfturner
added
the
New Feature
JGSweets
reviewed
Sep 20, 2022
examples/column_name_labeler.ipynb
Outdated
| "id": "da0e97ee-8d6d-4631-9b55-78ed904d5f41", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "### Predicting with the regex labeler\n", |
There was a problem hiding this comment.
fixed in next push
JGSweets
reviewed
Sep 20, 2022
examples/column_name_labeler.ipynb
Outdated
Comment on lines
96
to
139
| "# pre processor \n", | ||
| "preprocessor = dp.labelers.data_processing.DirectPassPreprocessor()\n", | ||
| "\n", | ||
| "# model\n", | ||
| "model = dp.labelers.column_name_model.ColumnNameModel(\n", | ||
| " parameters=parameters,\n", | ||
| " label_mapping=label_mapping,\n", | ||
| ")\n", | ||
| "\n", | ||
| "\n", | ||
| "# post processor\n", | ||
| "postprocessor = dp.labelers.data_processing.ColumnNameModelPostprocessor()" |
There was a problem hiding this comment.
Instead of manually loading, could we just use a load_from_library? or at least show that at the top so users know they can use a built-in labeler?
micdavis
previously approved these changes
Sep 20, 2022
micdavis
approved these changes
Sep 20, 2022
JGSweets
approved these changes
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.