DataProfiler: hotfix for handling nan values in diff
#647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micdavis
requested review from
JGSweets,
ksneab7,
taylorfturner and
tyfarnan
as code owners
micdavis
commented
Sep 20, 2022
| @@ -1,11 +1,10 @@ | |||
| """Contains functions for checking for installations/dependencies.""" | |||
There was a problem hiding this comment.
this file was updated from pre-commit
micdavis
commented
Sep 20, 2022
dataprofiler/tests/profilers/test_numeric_stats_mixin_profile.py
Outdated
Show resolved
Hide resolved
micdavis
commented
Sep 20, 2022
dataprofiler/tests/profilers/test_numeric_stats_mixin_profile.py
Outdated
Show resolved
Hide resolved
JGSweets
reviewed
Sep 20, 2022
micdavis
force-pushed
the
numeric_nan_diff_hotfix
branch
from
09a83cf
to
3e60a7f
Compare
micdavis
commented
Sep 20, 2022
| @@ -140,7 +140,7 @@ def setUpClass(cls): | |||
| "id": [ | |||
| {}, | |||
| { | |||
| "bin_counts": "unchanged", | |||
| "bin_counts": [[1], [1, 1, 2], []], | |||
There was a problem hiding this comment.
updated outputs based on the changes made to find_diff_of_lists_and_sets(stat1, stat2)
micdavis
commented
Sep 20, 2022
| @@ -61,7 +61,7 @@ def test_find_diff(self): | |||
|
|
|||
| # Ensure lists and sets are handled appropriately | |||
| self.assertEqual( | |||
| "unchanged", utils.find_diff_of_lists_and_sets([3, 2], [2, 3, 2]) | |||
| [[], [3, 2], [2]], utils.find_diff_of_lists_and_sets([3, 2], [2, 3, 2]) | |||
There was a problem hiding this comment.
updated outputs based on the changes made to find_diff_of_lists_and_sets(stat1, stat2)
micdavis
commented
Sep 20, 2022
| unique2 = [element for element in stat2 if element not in stat1] | ||
| diff = [unique1, shared, unique2] | ||
| elif set(stat1) != set(stat2) or len(stat1) != len(stat2): | ||
| temp_stat1 = list(copy.deepcopy(stat1)) |
There was a problem hiding this comment.
added deepcopy but then assigned to list because testing output expects lists not sets
JGSweets
approved these changes
Sep 20, 2022
taylorfturner
approved these changes
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
find_diff_of_lists_and_sets()handlesnanvalues now