Static typing for profilers #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonywu315
requested review from
JGSweets,
ksneab7,
taylorfturner,
micdavis and
tyfarnan
as code owners
JGSweets
reviewed
Sep 26, 2022
JGSweets
reviewed
Sep 26, 2022
JGSweets
reviewed
Sep 26, 2022
JGSweets
reviewed
Sep 26, 2022
| @@ -336,9 +336,11 @@ def diff(self, other_profile: DataLabelerColumn, options: Dict = None) -> Dict: | |||
|
|
|||
| differences = { | |||
| "data_label": utils.find_diff_of_lists_and_sets(labels, other_labels), | |||
| "avg_predictions": utils.find_diff_of_dicts(avg_preds, other_avg_preds), | |||
| "avg_predictions": utils.find_diff_of_dicts( | |||
| avg_preds, other_avg_preds # type: ignore | |||
There was a problem hiding this comment.
why does this need # type: ignore?
There was a problem hiding this comment.
avg_preds and other_avg_preds can both be None and utils.find_diff_of_dicts does not take in None
There was a problem hiding this comment.
Would this not indicate a code bug if find_diff_of_dicts cannot handle None, but we might be inserting it?
There was a problem hiding this comment.
I changed find_diff_of_dicts to handle None in the same way that the other find_diff functions do.
JGSweets
reviewed
Sep 26, 2022
JGSweets
reviewed
Sep 26, 2022
JGSweets
reviewed
Sep 26, 2022
JGSweets
reviewed
Sep 26, 2022
auto-merge was automatically disabled
September 26, 2022 15:21
Head branch was pushed to by a user without write access
auto-merge was automatically disabled
September 27, 2022 17:18
Head branch was pushed to by a user without write access
JGSweets
suggested changes
Sep 27, 2022
auto-merge was automatically disabled
September 27, 2022 18:49
Head branch was pushed to by a user without write access
JGSweets
approved these changes
Sep 27, 2022
taylorfturner
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#608