Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add static typing to data labeler and abstract classes #664

Merged
merged 3 commits into from
Sep 27, 2022
Merged

Add static typing to data labeler and abstract classes #664

merged 3 commits into from
Sep 27, 2022

Conversation

tonywu315
Copy link
Contributor

@JGSweets JGSweets enabled auto-merge (squash) September 26, 2022 20:53
@taylorfturner taylorfturner added the static_typing mypy static typing issues label Sep 27, 2022
tonywu315
tonywu315 commented Sep 27, 2022
View reviewed changes
dataprofiler/labelers/base_data_labeler.py
batch_size: int = 32,
predict_options: Dict[str, bool] = None,
error_on_mismatch: bool = False,
verbose: bool = True,
Copy link
Contributor Author

@tonywu315 tonywu315 Sep 27, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the default of verbose from 1 to True because it is only used in self._model.predict(), which takes in a bool.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@JGSweets JGSweets merged commit 3e5c878 into capitalone:main Sep 27, 2022
@tonywu315 tonywu315 deleted the static_typing/labelers/data_labeler branch September 27, 2022 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JGSweets JGSweets JGSweets approved these changes

@taylorfturner taylorfturner taylorfturner approved these changes

@ksneab7 ksneab7 Awaiting requested review from ksneab7

@micdavis micdavis Awaiting requested review from micdavis

@tyfarnan tyfarnan Awaiting requested review from tyfarnan

Assignees
No one assigned
Labels
static_typing mypy static typing issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tonywu315 @JGSweets @taylorfturner