Added static typing to data.py and filepath_or_buffer.py #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sanketh7
requested review from
JGSweets,
ksneab7,
taylorfturner,
micdavis and
tyfarnan
as code owners
taylorfturner
approved these changes
Oct 7, 2022
| """Release resources.""" | ||
| # Need to detach buffer if wrapped (i.e. BytesIO opened with 'r') | ||
| if self._is_wrapped: | ||
| self._filepath_or_buffer = cast(TextIOWrapper, self._filepath_or_buffer) # guaranteed by self._is_wrapped |
There was a problem hiding this comment.
potential for follow-up around casting and ensuring typing declaration is right and/or code is corrected to avoid the change of a wrong type
| wrapper = self._filepath_or_buffer | ||
| self._filepath_or_buffer = wrapper.buffer | ||
| wrapper.detach() | ||
|
|
||
| if isinstance(self._filepath_or_buffer, (StringIO, BytesIO)): | ||
| self._filepath_or_buffer.seek(0) | ||
| else: | ||
| self._filepath_or_buffer = cast(IO, self._filepath_or_buffer) # can't be str due to conversion in __enter__ |
There was a problem hiding this comment.
potential for follow-up around casting and ensuring typing declaration is right and/or code is corrected to avoid the change of a wrong type
JGSweets
approved these changes
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#610