Includes mypy in pre-commit and fixes last needed updates #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JGSweets
added
Bug
JGSweets
requested review from
ksneab7,
taylorfturner,
micdavis and
tyfarnan
as code owners
JGSweets
commented
Oct 18, 2022
Comment on lines
+46
to
+47
| additional_dependencies: ['types-setuptools', 'types-python-dateutil', | ||
| 'types-requests', 'types-chardet', 'types-six'] |
There was a problem hiding this comment.
libs required by mypy
JGSweets
changed the title
|
LGTM... will approve ASAP:
|
JGSweets
changed the title
taylorfturner
approved these changes
Oct 19, 2022
micdavis
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General typing updates and mypy in pre-commit