Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework Graph Test for mocking missing imports #736

Merged
merged 3 commits into from
Dec 5, 2022

Conversation

JGSweets
Copy link
Collaborator

@JGSweets JGSweets commented Dec 3, 2022

No description provided.

@taylorfturner taylorfturner enabled auto-merge (squash) December 3, 2022 13:41
@taylorfturner taylorfturner added Bug Something isn't working Medium Priority Significant improvement or bug / feature reducing overall performance labels Dec 3, 2022
@taylorfturner
Copy link
Contributor

Validated that this does fix the graph.py test issue mentioned in #733.

Running DATAPROFILER_SEED=0 python3 -m unittest discover -p "test*.py" returns the following

======================================================================
ERROR: test_merge_profile_list (dataprofiler.tests.profilers.test_utils.TestProfileDistributedMerge)
A top-level function which takes in a list of profile objects, merges

======================================================================
ERROR: test_odd_merge_profile_list (dataprofiler.tests.profilers.test_utils.TestProfileDistributedMerge)
A top-level function which takes in a list of profile objects, merges
----------------------------------------------------------------------

OSError: [Errno 24] Too many open files

----------------------------------------------------------------------
Ran 905 tests in 818.749s

FAILED (errors=2)
  • could be an issue with my local environment
  • and totally can deal with this in a separate PR.... so this PR is still LGTM on my end 👍

@taylorfturner taylorfturner merged commit 50dae26 into capitalone:main Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Medium Priority Significant improvement or bug / feature reducing overall performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants