Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create BaseColumnProfiler.to_dict to make JSONable #766

Merged
merged 2 commits into from
Feb 27, 2023
Merged

Create BaseColumnProfiler.to_dict to make JSONable #766

merged 2 commits into from
Feb 27, 2023

Conversation

kshitijavis
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Feb 21, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@taylorfturner taylorfturner added the New Feature A feature addition not currently in the library label Feb 21, 2023
@JGSweets
Copy link
Collaborator

JGSweets commented Feb 21, 2023 •
edited

@kshitijavis it looks like pre-commit will need to be run locally and updates committed / pushed.

Otherwise, LGTM.

@taylorfturner taylorfturner enabled auto-merge (squash) February 22, 2023 18:53
@taylorfturner taylorfturner merged commit 41ff289 into capitalone:main Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JGSweets JGSweets JGSweets approved these changes

@ksneab7 ksneab7 ksneab7 approved these changes

@taylorfturner taylorfturner Awaiting requested review from taylorfturner

@micdavis micdavis Awaiting requested review from micdavis

@tyfarnan tyfarnan Awaiting requested review from tyfarnan

Assignees

@kshitijavis kshitijavis

Labels
New Feature A feature addition not currently in the library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kshitijavis @CLAassistant @JGSweets @ksneab7 @taylorfturner